-
Couldn't load subscription status.
- Fork 1.3k
Add slackin engllish translation module prototype, translation tests & ... #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…& spaninsh & deutsche translations add locale.js add es, en localization add lang param to splash.js import locale and create locale instance in splash add lang param to bin/slackin fix bin/slackin to receive lang param update Makefile add clean let the user loads more than one lang for localization from cli export languajes on locale.js change slackin lang param to receive an array change splash.js lang param to be an array of locale objets update Makefile, remove locale folder from build remove locale/ add comments add localization stringas fix undefined error on lang not defined in locale.js remove white space Typo "Languaje" Add German Add build instructions choose slackin language based on Accept-Language header add export default set default language to en & check request header accept language require langs setted as params add try@catch to avoid missing locale module error remove old locale object adding tests assign languages passed on bin/slackin as param to (slackin)params fix default langs param value & create instance of locale before creating (splash) fix (slackin) default param initialization add langs to program as parameters to (slackin) add travis.yml add test to package.json update travis.yml, downgrade node version to 2.0 Update Readme.md update travis.yml, downgrade node version to 0.11 fix Makefile, it was duplicating locale folder add translations.js test. This test checks every prototype on the locale folder have the methods needed for slackin translations fix error messages fix request.headers undefined bug add test param to package.json add 2 test, checking once created a slackin instance a request response statusCode equals 200 & check the response body is correct acording to english language returning string for simple elements in localization objects update translations prototype export update translations import Add config params for slackin constructor update translations prototypes tests update gitignore update test, change translations constructor update test, change translations constructor add slack token for testing
|
@vrunoa super interested in this. We should clean it up and merge it <3 |
|
hey @rauchg i'll clean it up, update my repo which is quite behind master and let you know. |
|
@rauchg I merged the repo and rewrite a bit of the localization code, let me know if you're OK with this implementation or want to change something. |
|
I'll add Polish translations when this pull request will go live. Thanks for the work! |
| .option('-s, --silent', 'Do not print out warns or errors') | ||
| .option('-C, --coc <coc>', 'Full URL to a CoC that needs to be agreed to') | ||
| .option('-c, --css <file>', 'Full URL to a custom CSS file to use on the main page') | ||
| .option('-l, --locale [<locale>]', 'One or more comma-separated desired localization translations to serve', 'en') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you looked at using L20n?
...spanish, deutsche translations