fix: resolve double prompt and non-functional gorename fallback #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a UX issue where we're being prompted twice for the new identifier name when performing a rename operation with an active LSP client.
Problem
The current implementation shows a prompt to get the new identifier name, and then checks if an LSP client is available. If a client exists, it calls lsprename() which shows its own prompt, resulting in being asked twice for the same input.
Solution
Check for the LSP client availability before prompting. This ensures we only see one prompt:
If LSP client is available: Use lsprename() directly (with its built-in prompt)
If no LSP client: Show prompt and proceed with gorename fallback
Tests for go_fillstruct were already failing before my changes
Fixes #586