Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add RayClusterProvisioned Condition Type #2301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2024
Merged

Add RayClusterProvisioned Condition Type #2301

merged 2 commits into from
Aug 12, 2024

Conversation

@Yicheng-Lu-llll
Copy link
Collaborator

@Yicheng-Lu-llll Yicheng-Lu-llll commented Aug 10, 2024 •
edited
Loading

Why are these changes needed?

See #2297 for the reason.

RayClusterProvisioned represents the first time all Ray pods are ready. So after RayClusterProvisioned is set to true for the first time, It will not change any more:

    Last Transition Time:   2024-08-10T23:00:02Z
    Message:                All Ray Pods are ready for the first time
    Reason:                 AllPodRunningAndReadyFirstTime
    Status:                 True
    Type:                   RayClusterProvisioned

Related issue number

Closes #2297

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@Yicheng-Lu-llll
change RayClusterReady to RayClusterProvisioned
befc20c 
Signed-off-by: Yicheng-Lu-llll <[email protected]>
@Yicheng-Lu-llll
fix lint
cc30b60 
Signed-off-by: Yicheng-Lu-llll <[email protected]>
Yicheng-Lu-llll
Yicheng-Lu-llll commented Aug 10, 2024
View reviewed changes
ray-operator/controllers/ray/raycluster_controller_test.go

By("Check RayCluster HeadPodReady condition is true")
// The head pod is ready, so RayClusterReady condition should be added and set to True.
// The head pod is ready, so HeadPodReady condition should be added and set to True.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix a typo

@Yicheng-Lu-llll Yicheng-Lu-llll marked this pull request as ready for review August 10, 2024 23:05
@Yicheng-Lu-llll
Copy link
Collaborator Author

cc @kevin85421 @andrewsykim

@kevin85421 kevin85421 self-assigned this Aug 12, 2024
@kevin85421 kevin85421 merged commit f232b5b into ray-project:master Aug 12, 2024
@andrewsykim andrewsykim mentioned this pull request Aug 13, 2024
Merged
4 tasks
@Yicheng-Lu-llll Yicheng-Lu-llll mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

Assignees

@kevin85421 kevin85421

Labels

1.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Conditions HeadPodReady and RayClusterReady have overlapping meanings

2 participants

@Yicheng-Lu-llll @kevin85421