[serve][llm] CPU mode Release test #59564
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seiji Eicher <[email protected]>
Signed-off-by: Seiji Eicher <[email protected]>
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a release test for CPU-only mode in Ray Serve LLM, which is a great follow-up to the initial implementation. The changes are well-structured, with a new test configuration, a BYOD script for setting up the environment, and the test script itself.
My main feedback is on the test script release/llm_tests/serve/test_llm_serve_cpu_mode.py, where a time.sleep() is used. This can introduce flakiness. I've suggested replacing it with a more robust condition check that waits for both the application to be running and the model to be available via the API.
Overall, this is a solid addition to the release testing suite.
Signed-off-by: Seiji Eicher <[email protected]>
Signed-off-by: Seiji Eicher <[email protected]>
Signed-off-by: Seiji Eicher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #58334, add a release test
Related issues
N/A
Additional information