Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bugfix - uv_runtime_env_hook.py #59567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AYou0207 wants to merge 6 commits into
base: master
Choose a base branch
from
Open

bugfix - uv_runtime_env_hook.py #59567

AYou0207 wants to merge 6 commits into from

Conversation

@AYou0207
Copy link

@AYou0207 AYou0207 commented Dec 19, 2025

Description

The following demo breaks using current ray codebase.

uv init --package bugdemo && cd bugdemo && uv add ray && cat > src/bugdemo/main.py << EOF
import ray
def main():
    ray.init()
if __name__ == '__main__':
    main()
EOF && uv pip install -e . && uv run -m bugdemo.main

This PR fixes it.

Related issues

N/A

@AYou0207
bugfix
3a69a84 
Signed-off-by: AYou0207 <[email protected]>
@AYou0207 AYou0207 requested a review from a team as a code owner December 19, 2025 04:16
cursor[bot]
cursor bot reviewed Dec 19, 2025
View reviewed changes
gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 19, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a bug in uv_runtime_env_hook.py that caused an AssertionError when uv run was used with options but no explicit command (e.g., uv run -m my_module). The change correctly adds a check to handle cases where the parsed command is an empty list. However, this fix appears to be incomplete as it introduces a subsequent issue on line 327, where uv_run_args is incorrectly assigned an empty list when command is empty. This leads to py_executable in the runtime environment being set to an empty string. I've added a specific comment with suggestions on how to address this. I also left a comment to improve the clarity of the code comment that was added.

@AYou0207
bugfix
8c83233 
Signed-off-by: AYou0207 <[email protected]>
@AYou0207
lint
4913d16 
Signed-off-by: AYou0207 <[email protected]>
@ray-gardener ray-gardener bot added core Issues that should be addressed in Ray Core community-contribution Contributed by the community labels Dec 19, 2025
@codope codope added the go add ONLY when ready to merge, run all tests label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@sampan-s-nayak sampan-s-nayak

Labels

community-contribution Contributed by the community core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AYou0207 @codope @sampan-s-nayak