[Core] Fix incorrect task reference in test_cancel_recursive_tree verification loop #59574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yicheng <[email protected]>
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug in the test_cancel_recursive_tree test. The original code used a stale loop variable, which led to incorrect test verification. The submitted change replaces it with the correct reference, ensuring that all tasks are properly checked. The fix is accurate, minimal, and improves the reliability of the test suite. The change looks good to me.
edoakes
approved these changes
Dec 19, 2025
Member
Author
|
@edoakes Thank you！ |
Yicheng-Lu-llll
added a commit
to Yicheng-Lu-llll/ray
that referenced
this pull request
Dec 22, 2025
…ification loop (ray-project#59574) ## Description In test_cancel_recursive_tree, the concurrent test case: 1. Creates 10 ChildActor instances 2. Submits 10 Actor.run tasks, each spawning child tasks on a ChildActor 3. Cancels 5 tasks with recursive=True and 5 with recursive=False 4. Expects that for recursive=True, both the parent task and child tasks are cancelled; for recursive=False, only the parent task is cancelled The issue is in the verification loop: when checking if the parent tasks are cancelled, the test uses `run_ref` (a stale loop variable from the previous loop) instead of run_refs[i]. This causes the test to verify the same task (`run_refs[9]`) ten times, rather than verifying all 10 tasks. This PR fixes the issue by using `run_refs[i]` to correctly verify each task. ## Related issues > Link related issues: "Fixes ray-project#1234", "Closes ray-project#1234", or "Related to ray-project#1234". ## Additional information > Optional: Add implementation details, API changes, usage examples, screenshots, etc. Signed-off-by: yicheng <[email protected]> Co-authored-by: yicheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In test_cancel_recursive_tree, the concurrent test case:
The issue is in the verification loop: when checking if the parent tasks are cancelled, the test uses
run_ref(a stale loop variable from the previous loop) instead of run_refs[i]. This causes the test to verify the same task (run_refs[9]) ten times, rather than verifying all 10 tasks.This PR fixes the issue by using
run_refs[i]to correctly verify each task.Related issues
Additional information