refactor(log.rs): improve logging structure and error handling #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RainRaydium
reviewed
Dec 26, 2024
There was a problem hiding this comment.
- I thank the
into_u8function no need to change.Because this change will affect other files. - Update
pub fn encode_ray_log<T: Serialize>(log: &T) -> Result<String, &'static str> {asfn serialize_ray_log<T: Serialize>(log: &T) -> Result<String, &'static str> { - Update
pub fn log_ray_log<T: Serialize>(log: &T) {aspub fn encode_ray_log<T: Serialize>(log: &T) {to ensure the interface used externally remains unchanged.
| } | ||
|
|
||
| pub fn into_u8(&self) -> u8 { | ||
| pub fn to_u8(&self) -> u8 { |
There was a problem hiding this comment.
The function no need to change.Because this change will affect other files
| LogType::Deposit => { | ||
| let log: DepositLog = bincode::deserialize(&bytes).unwrap(); | ||
| println!("{:?}", log); | ||
| pub fn log_ray_log<T: Serialize>(log: &T) { |
There was a problem hiding this comment.
How about use encode_ray_log for not affect other files.
And change pub fn encode_ray_log<T: Serialize>(log: &T) -> Result<String, &'static str> {
as serialize_ray_log?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
log.rsfor Enhanced Logging and UsabilityChanges Made
LogTypeconversion methods for better extensibility and clarity.decode_ray_logto improve resilience against corrupted log data.LogTypevariants.