Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@terwey
Copy link
Collaborator

@terwey terwey commented Oct 28, 2025

Summary

  • guard the OrdersTable price cell from showing BBO comparisons when the order side is unknown or the venue quote is invalid
  • type the price feed map with HyperliquidBestBidOffer to align with the generated API schema

Testing

  • pnpm eslint

https://chatgpt.com/codex/tasks/task_e_6900d2ca501c832686fc0552cbc40e11

@terwey terwey changed the base branch from lytenyte to main October 28, 2025 16:55
@terwey
Copy link
Collaborator Author

terwey commented Oct 30, 2025

@codex even before this PR the entire BBO is not visible in the table, please investigate.

@chatgpt-codex-connector
Copy link

Summary

Testing

  • pnpm --dir webui/app exec eslint src

View task →

@terwey
Copy link
Collaborator Author

terwey commented Oct 30, 2025

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@terwey terwey merged commit 55e4691 into main Oct 30, 2025
2 checks passed
@terwey terwey deleted the codex/github-mention-featwebui-lytenyte-grid,-modular-orderst branch October 31, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants