fix(webui): restore live order updates by listening to named SSE events #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents** The backend emits `/sse/orders` frames with explicit event names (`three_commas_event`, `hyperliquid_submission`, etc.), but our React consumers were using `EventSource.onmessage`, which only fires for the default `message` event. As a result, live updates never reached the UI. Introduce `utils/orderStream.attachOrderStreamHandlers` to register handlers for all order-stream event types and return a single detach function. Migrate the following to use the shared helper and ensure listeners are removed during cleanup before closing the stream: * `BotsDealsExplorer` * `OrdersTable/filters/BotsFilter` * `OrdersTable/filters/DealsFilter` * `OrdersTable/hooks/useOrdersData` * `StatsCards` Result: live updates for orders, bots, deals, and statistics now flow to the browser as expected.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Collaborator
Author
|
@codex any other reviews? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(webui): restore live order updates by listening to named SSE events
The backend emits
/sse/ordersframes with explicit event names (three_commas_event,hyperliquid_submission, etc.), but our React consumers were usingEventSource.onmessage, which only fires for the defaultmessageevent. As a result, live updates never reached the UI.Introduce
utils/orderStream.attachOrderStreamHandlersto register handlers for all order-stream event types and return a single detach function. Migrate the following to use the shared helper and ensure listeners are removed during cleanup before closing the stream:BotsDealsExplorerOrdersTable/filters/BotsFilterOrdersTable/filters/DealsFilterOrdersTable/hooks/useOrdersDataStatsCardsResult: live updates for orders, bots, deals, and statistics now flow to the browser as expected.