fix: abort stale order fetches when SSE updates arrive #33
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (initialFetchPendingRef.current && !abortController.signal.aborted) { | ||
| initialFetchPendingRef.current = false; | ||
| abortController.abort(); | ||
| } |
There was a problem hiding this comment.
Avoid aborting initial orders fetch when metadata events arrive
When the SSE handler sees any event it sets initialFetchPendingRef and immediately aborts the in-flight fetchOrders. For events that include metadata the handler calls only refreshOrdersForMetadata(metadata) and never triggers a full fetchOrders run. If such a metadata event arrives before the initial request finishes—a common case when the stream emits updates immediately—the full list of orders is never loaded and the table shows only the updated order(s). Consider letting the original fetch complete or triggering a full reload after aborting so the base dataset is populated.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_69039948e1a48326b5fd9eb13e38ff55