feat: audit skipped scaled orders #47
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| multiplier_updated_by TEXT NOT NULL, | ||
| created_at_utc INTEGER NOT NULL DEFAULT (CAST(unixepoch('now','subsec') * 1000 AS INTEGER)), | ||
| submitted_order_id TEXT, | ||
| skipped INTEGER NOT NULL DEFAULT 0, | ||
| skip_reason TEXT, |
There was a problem hiding this comment.
Add migration for new scaled order audit columns
The commit adds skipped and skip_reason columns to scaled_orders, but the schema is only applied through CREATE TABLE IF NOT EXISTS in storage.New. For SQLite databases that were created before this change, the table already exists and these statements will be skipped, leaving the old schema in place while the new queries now read and write skipped/skip_reason. Upgrading the binary would therefore fail with no such column errors when recording scaled orders. A migration (e.g. ALTER TABLE scaled_orders ADD COLUMN …) or a versioned schema update is needed before referencing the new fields.
Useful? React with 👍 / 👎.
acc4fa7
into
codex/update-schema-and-queries-for-orders
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_6904c46a5cb88326ba552ce3d1bbde55