action: add guard for generated code #57
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| name: Generated Code Guard | ||
|
|
||
| on: | ||
| push: | ||
| paths: | ||
| - 'storage/sqlcgen/**' | ||
| - 'internal/api/ops.gen.go' | ||
| pull_request: | ||
| paths: | ||
| - 'storage/sqlcgen/**' | ||
| - 'internal/api/ops.gen.go' |
There was a problem hiding this comment.
Guard never runs when only sources change
The workflow watches storage/sqlcgen/** and internal/api/ops.gen.go for both push and pull_request events, then regenerates those files to verify they are committed. However, the SQL and OpenAPI definitions that produce these outputs (storage/sqlc/**, openapi.yaml, oapi.yaml, etc.) are not included in the trigger or in the changed-files groups. A contributor can modify the source schema/spec without touching the generated artifacts and CI will not run this guard, allowing stale generated code to merge unnoticed. Consider adding the source files to the paths filter and the files_yaml so the job regenerates when the true inputs change.
Useful? React with 👍 / 👎.
No description provided.