fix: aggregate venue positions by venue key #88
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return OrderSnapshot{ | ||
| OrderId: o.oid, | ||
| OrderId: o.oid, | ||
| Identifier: recomma.OrderIdentifier{ | ||
| OrderId: o.oid, | ||
| }, |
There was a problem hiding this comment.
Populate OrderIdentifier with venue and wallet data
The new calculateVenuePositions groups positions by OrderSnapshot.Identifier.VenueID and Wallet, but orderState.snapshot only fills the identifier with the legacy OrderId value. The service never records venue or wallet information when tracking orders, so every snapshot produced in production will carry empty VenueID/Wallet fields, causing any call to calculateVenuePositions to collapse all fills into a single default key instead of per-venue buckets. Consider persisting the venue/wallet when events or statuses are applied and populating them here so the aggregation can return meaningful results.
Useful? React with 👍 / 👎.
Summary
OrderIdentifierstruct to capture venue, wallet, and order IDcalculateVenuePositionsthat groups net fills by(venue, wallet)instead of copying an arbitrary order IDFixes #84
https://chatgpt.com/codex/tasks/task_e_690bf61fd7a48326b7ea3abcb5df69c7