fix(ui): extract isPrimary flag from venue.flags in settings view #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The settings view builds its wallet list from fetchVenues() in loadVenuesFromAPI, but the returned VenueRecord objects store the primary flag inside venue.flags.is_primary. The code was not extracting this value when populating the state, so downstream actions (edit, delete) that rely on venue.isPrimary would fail backend validation when no primary venue was marked. This fix decodes flags.is_primary when mapping venues so the isPrimary property is correctly set on VenueWithAssignments objects, ensuring that exactly one primary venue is always preserved during updates. Fixes the "invalid payload: no primary venue found" validation error when editing or deleting the primary wallet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The settings view builds its wallet list from fetchVenues() in loadVenuesFromAPI, but the returned VenueRecord objects store the primary flag inside venue.flags.is_primary. The code was not extracting this value when populating the state, so downstream actions (edit, delete) that rely on venue.isPrimary would fail backend validation when no primary venue was marked.
This fix decodes flags.is_primary when mapping venues so the isPrimary property is correctly set on VenueWithAssignments objects, ensuring that exactly one primary venue is always preserved during updates.
Fixes the "invalid payload: no primary venue found" validation error when editing or deleting the primary wallet.