Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 11, 2022. It is now read-only.

Merge pull request #21 from reactioncommerce/feat-aldeed-18-update-meteor #21

Merged
willopez merged 1 commit into from
Jan 28, 2020
Merged

Merge pull request #21 from reactioncommerce/feat-aldeed-18-update-meteor #21

willopez merged 1 commit into from
Jan 28, 2020

Conversation

@aldeed
Copy link
Contributor

@aldeed aldeed commented Jan 28, 2020

Resolves #18
Impact: minor
Type: feature

Changes

The project now runs on Meteor 1.9 (Node 12.14.0). Other NPM packages are updated as necessary to match.

Breaking changes

None

Testing

docker-compose down -v
ln -s docker-compose.dev.yml docker-compose.override.yml
docker-compose up --build -d
docker-compose logs -f

After the app starts, try login flow from admin or storefront and verify it works.

@aldeed
feat: update to Meteor 1.9
dc60720 
Signed-off-by: Eric Dobbertin <[email protected]>
@aldeed aldeed requested a review from willopez January 28, 2020 01:23
willopez
willopez approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willopez willopez changed the title feat: update to Meteor 1.9 Merge pull request #21 from reactioncommerce/feat-aldeed-18-update-meteor Jan 28, 2020
@willopez willopez merged commit dca9d55 into trunk Jan 28, 2020
@willopez willopez deleted the feat-aldeed-18-update-meteor branch January 28, 2020 18:24
This was referenced Feb 4, 2020
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Aug 25, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@willopez willopez willopez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update to Meteor 1.9

3 participants

@aldeed @willopez