Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(GraphQL): add Account.primaryEmailAddress resolver #4647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nnnnat merged 3 commits into from
Sep 20, 2018
Merged

feat(GraphQL): add Account.primaryEmailAddress resolver #4647

nnnnat merged 3 commits into from
Sep 20, 2018

Conversation

@aldeed
Copy link
Contributor

@aldeed aldeed commented Sep 20, 2018

Impact: minor
Type: feature

Changes

Provide a simpler way for GraphQL clients to get the default account email address: Account.primaryEmailAddress

Breaking changes

None

Testing

{
  viewer {
    name
    emailRecords {
      provides
      address
      verified
    }
    primaryEmailAddress
  }
}

primaryEmailAddress should be set and should match the email record with "default" as its provides value.

@aldeed aldeed requested a review from nnnnat September 20, 2018 15:02
@aldeed aldeed added this to the North Maroon milestone Sep 20, 2018
@aldeed aldeed self-assigned this Sep 20, 2018
nnnnat
nnnnat approved these changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@nnnnat nnnnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

@nnnnat nnnnat merged commit 988d524 into release-2.0.0 Sep 20, 2018
@nnnnat nnnnat deleted the feat-aldeed-graphql-viewer-additions branch September 20, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nnnnat nnnnat nnnnat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aldeed aldeed

Labels

None yet

Projects

None yet

Milestone

North Maroon

Development

Successfully merging this pull request may close these issues.

3 participants

@aldeed @nnnnat