fix: submitting the template edit form now works #4665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Fixed |
jeffcorpuz
approved these changes
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4660
Impact: minor
Type: bugfix
Issue
Clicking Save on the template edit form did not do anything
Solution
The form "submit' event was being swallowed somewhere, likely an autoform issue. This only affects "normal" autoform submission, so I switched it to use the "method-update" submission type. This was the only autoform in the codebase that used "normal".
Breaking changes
This required changing the signature of the "templates/email/update" Meteor method. This could be breaking to customized code.
Testing
Verify you can save changes to templates as an operator.