-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[WIP] feat: shipping method restrictions and surcharges #4783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for a fulfillment group
… items in the cart
…ction into feat-shipping-rules
…ction into feat-shipping-rules
create fulfillment surcharges
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] [WIP] [WIP]
Impact: major
Type: feature
Issue
Shops should be able to restrict available shipping methods based on shipping location and attributes of items inside an order (price, brand, type of item, etc). They should also be able to apply surcharges to an order based on the same criteria.
Solution
Create both universal and per-method ways to allow or deny a shipping method based on the address attached to the an order, and attributes attached to items in an order. This is done by creating a
FlatRateFulfillmentMethodRestrictionscollection, and creatingallowanddenyrestrictions for each method inside this collection.Create both universal and per-method ways to add surcharges to an order based on the address attached to the an order, and attributes attached to items in an order. This is done by creating a
Surchargescollection, and applying the surcharges to an order if criteria matches.Breaking changes
None. These are add-on features. If no Allow or Deny restrictions are found on a method, the method will be allowed in the same way it currently is. If no surcharges are found, nothing is different.
Testing [WIP]
Existing Test Updates
getFulfillmentMethodsWithQuotestest to allow our new code to work with it