Remove unused meteor methods #4815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieckhafer
approved these changes
Nov 21, 2018
Member
There was a problem hiding this comment.
👍 No logs / errors, was able to checkout and go through order flow with logged in, admin, and guest users.
The License Compliance is related to our own reaction-component-library, and is not a blocker for getting this merged.
We are aware of and working on a fix for the failing build_and_test test.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: feature
Changes
During a review of all Meteor methods, I identified several that are no longer used in 2.0 or could be easily removed. This PR removes them.
shop/getBaseLanguageshop/getCurrencyRatesshop/getWorkflowgetTemplateByNameorders/addOrderEmailtaxes/updateTaxCodeworkflow/coreOrderWorkflow/coreOrderProcessingworkflow/coreOrderWorkflow/coreOrderCompletedBreaking changes
If a custom plugin uses any of these methods, it will need to be updated.
Testing
Checking out and pushing an order through all statuses should be sufficient.