Fix Jest integration tests #4824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's now downloaded to node_modules/.cache so it's covered by the node_modules cache
spencern
approved these changes
Nov 29, 2018
| afterAll(async () => { | ||
| await testApp.collections.Shops.remove({ _id: internalShopId }); | ||
| await testApp.collections.Catalog.remove({ _id: internalCatalogItemId }); | ||
| await Promise.all(internalTagIds.map((_id) => testApp.collections.Tags.remove({ _id }))); |
Contributor
There was a problem hiding this comment.
Is this map just to loop through and remove all the tags?
| context: { | ||
| appEvents, | ||
| collections: this.collections, | ||
| getFunctionsOfType: () => [], |
Contributor
There was a problem hiding this comment.
Is this a required property for context now?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4752
Impact: minor
Type: test
Issue
Many Jest integration tests were not working
Solution
Update to latest Jest and fix issues with the tests.
Also re-enabled running the Jest integration tests as a CI check, and that seems to be working now! 🤞
Breaking changes
None
Testing
test.skipanymore (except a few that were never written but were defined. Latest Jest now requires that you change those totest.skipwith a no-op function, which there is still some controversy around.)npm run test:integrationlocally and verify that all tests pass.