Update main Reaction app to use .env file
#4826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The one CI check failure is a known issue with feature deployment script that @griggheo is fixing separately. |
spencern
previously requested changes
Dec 3, 2018
Contributor
spencern
left a comment
There was a problem hiding this comment.
I think we can safely set the polling frequency to 10s and keep almost 100% of the performance improvements that we get at 60s
We might be able to go lower than that, but I haven't tested below 10000ms
@spencern says: I think we can safely reduce this to 10000 based on some testing I've done.
Contributor
Author
|
@spencern All comments resolved |
spencern
approved these changes
Dec 8, 2018
Contributor
spencern
left a comment
There was a problem hiding this comment.
I think this will help quite a bit. 👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4706
Impact: minor
Type: feature
Issue
Most services that make up the Reaction platform use a
.envfile in the root of the service folder to define environment variables that should be set while running. They also have apre-buildscript that the reaction-platform tool runs to create or update the.envfile from a.env.examplefile, which is committed.The Reaction API service does not have these.
Solution
Add the
.env-related files.Also added two environment variables to
.env.example, based on discussions elsewhere:Breaking changes
If you run Reaction locally, such as for development, you will now need to be sure there is a
.envfile with correct environment variables set in it. The.env.examplefile, with no changes, should work for most people. When running withreaction-platform, this should happen automatically. But if you've already been developing locally and you pull in this change, you'll need to runbin/setuponce. You can also runbin/setupanytime you pull in the future, to add any new ENV variables.How to run locally outside of Docker
While we recommend always developing within Docker (as part of Reaction Platform) it is possible to run locally directly on your host machine (Linux or OSX). If you do this, you'll need a
.envfile with slightly different URLs. Copy.envto.env.localand update.env.localto look like this:We've simply changed
hydraandmongohostnames tolocalhost. Everything else is the same.You can now run directly on your host machine, after starting
mongoandhydraservices in Docker, with this command:Testing
Follow the instructions for creating the
.env, and then make sure that the app starts, and run some simple smoke tests.