Add node_modules/.bin to PATH in docker #4820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldeed
approved these changes
Nov 29, 2018
aldeed
previously requested changes
Nov 29, 2018
Contributor
aldeed
left a comment
There was a problem hiding this comment.
Would it be better to do $APP_SOURCE_DIR/node_modules/.bin in case the dir changes in the base image?
Also, the way I usually do this is with npx command, but I don't see any harm with this change
34ab58a to
3bf1d60
Compare
Contributor
Author
|
OK I used |
ticean
approved these changes
Nov 29, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: chore
Issue
In the docker container I can't just run npm tools with CLIs like
eslintoutside of the defined npm scripts frompackage.json. Adding this directory to the PATH allows running such programs normally.Just a developer convenience.