Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(tag): add Display Title to Tag #4856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mikemurray merged 1 commit into from
Dec 7, 2018
Merged

feat(tag): add Display Title to Tag #4856

mikemurray merged 1 commit into from
Dec 7, 2018

Conversation

@machikoyasuda
Copy link
Contributor

@machikoyasuda machikoyasuda commented Dec 6, 2018 •
edited
Loading

Resolves #4843
Impact: minor
Type: feature

Issue

Solution

  • Add displayTitle to Tag schema, Tag GraphQL query
  • A displayTitle is an optional string on Tag.

Breaking changes

none

Testing

  1. Add a displayTitle to a Tag in the database
  2. Check the Tag data GraphiQL

screen shot 2018-12-06 at 2 50 16 pm

Tested with Starter-Kit: reactioncommerce/example-storefront#450

screen shot 2018-12-06 at 2 50 08 pm

Test with GraphiQL:
screen shot 2018-12-06 at 2 56 03 pm

@machikoyasuda machikoyasuda changed the base branch from master to release-2.0.0-rc.8 December 6, 2018 01:14
@machikoyasuda machikoyasuda changed the title [WIP] - feat(#4843): add Display Title to Tag [WIP] - feat(tag): add Display Title to Tag Dec 6, 2018
@machikoyasuda machikoyasuda changed the title [WIP] - feat(tag): add Display Title to Tag feat(tag): add Display Title to Tag Dec 6, 2018
@machikoyasuda machikoyasuda mentioned this pull request Dec 6, 2018
Merged
mikemurray
mikemurray approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikemurray mikemurray merged commit 374b9f1 into release-2.0.0-rc.8 Dec 7, 2018
@mikemurray mikemurray deleted the 4843-machikoyasuda-tag-titles branch December 7, 2018 02:41
@machikoyasuda
Copy link
Contributor Author

machikoyasuda commented Dec 7, 2018

㊗🎉

@machikoyasuda machikoyasuda mentioned this pull request Dec 13, 2018
Closed
@spencern spencern mentioned this pull request Jan 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikemurray mikemurray mikemurray approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@machikoyasuda @mikemurray