Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@impactmass
Copy link
Contributor

Fixup: #4835
Impact: major
Type: fix

Change

PR #4794 changed Hydra plugin's first route's name field from "OAuth Login" to "account/login to match plugin patterns/conventions across the app". This migration updates existing document(s) for the route to match the update.

Testing

Testing this requires switching branches and reseting the DB. So test this when about to make coffee or tea .

  • Checkout your local reaction core code to rc-7. The 404 Login issue existed as at that release. You can do this with git checkout tags/v2.0.0-rc.7.
  • Start with a fresh DB for this checked out tag. You can docker-compose down -v to remove existing DB data then docker-compose up after that. You can also point this to a new/separate DB if that's better.
  • Once the app starts, try a log in from the storefront, you should see the 404 problem (better done in incognito)
  • Then switch your reaction core branch to this one fixup-4794-impactmass-migrate-plugin-name, and restart the app
  • One the app restarts, try a log in from the storefront app, and confirm login is good

@impactmass impactmass requested a review from nnnnat December 10, 2018 17:17
Copy link
Contributor

@nnnnat nnnnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@nnnnat nnnnat merged commit 623ab6b into release-2.0.0-rc.8 Dec 11, 2018
@nnnnat nnnnat deleted the fixup-4794-impactmass-migrate-plugin-name branch December 11, 2018 15:01
@spencern spencern mentioned this pull request Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants