primaryShopId query fallback #4862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For primaryShopId GraphQL query
kieckhafer
approved these changes
Dec 14, 2018
Member
kieckhafer
left a comment
There was a problem hiding this comment.
Code looks good.
Starterkit works as expected.
👍
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4842
Impact: minor
Type: bugfix
Issue
The
primaryShopIdGraphQL query returnsnullif the domain to which you make the request isn't in the domains array of any shop. While it's not usually hard to add all domains to the list in a production db, this is an unnecessary burden for CI staging deploys and local development.Solution
Fall back to
Shops.findOne({ shopType: "primary" })Breaking changes
None
Testing
In MongoDB, clear the
domainsarray for all Shop documents. Verify that the starterkit storefront UI still displays without errors and functions as expected.