Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jeffcorpuz
Copy link
Contributor

@jeffcorpuz jeffcorpuz commented Dec 13, 2018

Resolves : https://github.com/reactioncommerce/automation-reaction-client/issues/28
Impact: minor
Type: chore

Issue

  • End to End tests were run locally on a machine for testing purposes, no integration within the CI workflow.
  • Feature branch deployments are not working as they are supposed to, disable until fixed.

Solution

  • Dockerize Reaction Automation Client properly
  • Integrate after successful deploy to a release environment at the very end
  • Execute tests

Testing

  1. Run through CI process (takes 30~ minutes)

Sample Successful Run:
https://circleci.com/gh/reactioncommerce/reaction/34548

Copy link
Contributor

@griggheo griggheo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@aldeed aldeed merged commit aef0b12 into release-2.0.0-rc.8 Dec 14, 2018
@aldeed aldeed deleted the test-e2e-integration branch December 14, 2018 18:08
@spencern spencern mentioned this pull request Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants