Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: add replace to remove comma from formatting #4916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spencern merged 4 commits into from
Jan 11, 2019
Merged

fix: add replace to remove comma from formatting #4916

spencern merged 4 commits into from
Jan 11, 2019

Conversation

@kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Jan 11, 2019 •
edited
Loading

This PR is the same as #4910 , just into our release-2.0.0-r.8 branch instead of develop

Resolves #4900
Impact: minor
Type: bugfix

Issue

Price ranges that included a number above 1000 would show up as NAN in the admin Grid. This is due to the currency being formatted twice, which in turn adds double commas into the string, which breaks the display.

Solution

Use our "new" getProductPriceRange to calculate the price range based off of min and max numbers, instead of the price range string.

Breaking changes

None

Testing

  1. Change the price of all of a products variants to anything over $1,000 (anything that will show a comma).
  2. See that the price range correctly displays on the Grid when you are logged in as an admin.
  3. See that the price is not broken on the Grid AND PDP when not logged in as an admin.

@kieckhafer kieckhafer requested a review from spencern January 11, 2019 17:47
spencern
spencern approved these changes Jan 11, 2019
View reviewed changes
Copy link
Contributor

@spencern spencern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Erik 👍

@spencern spencern merged commit 72181da into release-2.0.0-rc.8 Jan 11, 2019
@spencern spencern deleted the fix-kieckhafer-4900-currencyNANissue branch January 11, 2019 17:49
@kieckhafer kieckhafer mentioned this pull request Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@spencern spencern spencern approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kieckhafer @spencern