fix: migration 56 throwing an error #4934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Kieckhafer <[email protected]>
Contributor
|
@kieckhafer I would instead fix by adding Sorry I didn't catch this when reviewing |
Member
Author
|
@aldeed updated |
aldeed
approved these changes
Jan 24, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: bugfix
Issue
Migration 56 is throwing an error,
Error while migrating TypeError: Cannot read property 'namedContext' of null. It seems this error stems from the issue of having two different schemas forvariantandsimple, causing the issue with the update.There are various cases of this same error reported in github issues:
Meteor-Community-Packages/meteor-collection2#310
aldeed/meteor-collection2-core#12
Solution
Split the update into two different database calls.
Breaking changes
None
Testing