refactor: Update inventoryQuantity field to be inventoryInStock
#4930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldeed
requested changes
Jan 22, 2019
| canBackorder: canBackorder(variantOptions), | ||
| inventoryAvailableToSell: variant.inventoryAvailableToSell || 0, | ||
| inventoryInStock: variant.inventoryQuantity || 0, | ||
| inventoryInStock: variant.inventoryInStock || 0, |
Contributor
There was a problem hiding this comment.
This may not be the time to correct this, but inventoryInStock and inventoryAvailableToSell are optional in the catalog GraphQL schema, and it seems to me that null would mean something different from 0. If inventory isn't tracked in the product (null) but yet that becomes 0 in the catalog, that seems to be changing the meaning from "unknown" to "none".
So essentially I'm proposing that we remove the || 0 from all of these
...s/plugins/core/versions/server/migrations/56_change_inventoryQuantity_to_inventoryInStock.js
Show resolved
Hide resolved
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
bc1e3fd to
e039447
Compare
aldeed
approved these changes
Jan 22, 2019
Member
Author
|
@aldeed can this be merged? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: breaking|minor
Type: refactor
Issue
A recent update to how we calculate inventory added a new field,
inventoryAvailalbeToSell. This left us with two inventory fields,inventoryAvailalbeToSellandinventoryQuantity, in theProductscollection.In the
Catalogcollection, we renamedinventoryQuantitytoinventoryInStock, as it was a better description of what the field actually is.We initially left the
Productscollection alone, but feel like we should keep these field names in sync to avoid confusion.Solution
Rename the field
inventoryQuantitytoinventoryInStockin theProductscollection.Breaking changes
No breaking changes in Reaction code. If you use the
inventoryQuantityfield in any custom code, it will need to be updated.Testing