Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: tag ui bugs #4933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
machikoyasuda merged 13 commits into from
Jan 26, 2019
Merged

fix: tag ui bugs #4933

machikoyasuda merged 13 commits into from
Jan 26, 2019

Conversation

@mikemurray
Copy link
Member

@mikemurray mikemurray commented Jan 23, 2019 •
edited by machikoyasuda
Loading

Resolves #4921
Impact: minor
Type: bugfix

Issue

Fixing the following UI issues

  • Check marks in the table aren't using our design system checks (http://zpl.io/bzYjeKA)
  • Edit buttons (pencil icon) are left aligned in a column and should be centered
  • The visible/hidden column should have a header label = "Status"
  • Status column - Hidden status dots should be grey not red, red connotes error
  • The status and the action dropdown need to be consistent in their wording (ie make visible/hidden vs enable/disable)

Breaking changes

none.

Testing

Ensure the following changes have been made. The designs for reference: https://app.zeplin.io/project/5bda33eeed47f75de8f57ffb/screen/5c11b44ce095b2af89b86827

  • Edit buttons (pencil icon) are center aligned in their column
  • Checkbox looks like design system checkbox.
  • "Status" label about the visible/hidden column
  • Use "Visible" and "Hidden" in the bulk actions dropdown
  • Version number 1.0.0 shows up in shop settings

Screenshot

screen shot 2019-01-25 at 3 40 43 pm

@mikemurray mikemurray changed the title fix: tag ui bugs [WIP] fix: tag ui bugs Jan 24, 2019
@mikemurray
fix: status icon color
2c7ed4f 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
fix: unknown prop warning
9ffcbd9 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
feat: update component library
aab3c38 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
feat: add custom table select component
b037f78 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
feat: add theme overrides for checkbox
c0d5c70 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
feat: update style and select component for table
d539d6d 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
fix: update to latest components-context to resolve form submission i…
31eae89 
…ssues

Signed-off-by: Mike Murray <[email protected]>
@mikemurray
fix: use correct translations for bulk actions
effe802 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
fix: add heroMediaUrl field for add tag payload and mutation
046fb08 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
feat: add version field to registry
20db84e 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
fix: use major.minor.patch version number format
9c9687e 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray mikemurray changed the title [WIP] fix: tag ui bugs fix: tag ui bugs Jan 25, 2019
cassytaylor
cassytaylor suggested changes Jan 25, 2019
View reviewed changes
Copy link

@cassytaylor cassytaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, one small thing! Let's have the bulk action options text be "Make hidden" and "Make visible"

machikoyasuda
machikoyasuda approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@machikoyasuda machikoyasuda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The plugin version works:
    screen shot 2019-01-25 at 3 40 43 pm
  • The checkbox check good to me, but @cassytaylor should confirm
  • The alignment of the pencil look good, but @cassytaylor should confirm
  • Copy changes: Status, and dropdown look good

@mikemurray
Copy link
Member Author

mikemurray commented Jan 26, 2019

@cassytaylor updated text for the bulk actions

image

@machikoyasuda machikoyasuda merged commit 7e4c357 into develop Jan 26, 2019
@machikoyasuda machikoyasuda deleted the fix-4921-mikemurray-tag-ui-bugs branch January 26, 2019 00:24
@mikemurray mikemurray mentioned this pull request Jan 28, 2019
Merged
@jeffcorpuz jeffcorpuz mentioned this pull request Mar 1, 2019
Merged
@cassytaylor cassytaylor mentioned this pull request Dec 16, 2019
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@machikoyasuda machikoyasuda machikoyasuda approved these changes

@cassytaylor cassytaylor cassytaylor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikemurray @machikoyasuda @cassytaylor