Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@aldeed
Copy link
Contributor

@aldeed aldeed commented Jan 31, 2019

Impact: minor
Type: feature

Issue

It was not possible to pass indexing options such as unique: true when using the collectionIndex util function to create indexes on a MongoDB collection.

Solution

Added optional options argument and passed it through to createIndex

Breaking changes

Nope

Testing

Verify that the server starts up without errors.

@aldeed aldeed changed the base branch from master to develop January 31, 2019 16:44
@aldeed aldeed requested a review from kieckhafer January 31, 2019 16:44
@aldeed aldeed self-assigned this Jan 31, 2019
@aldeed aldeed added this to the πŸ” Torreys milestone Jan 31, 2019
@aldeed aldeed force-pushed the feat-aldeed-add-collectionIndex-options branch from fadeb24 to a375ebe Compare January 31, 2019 16:45
Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ Starts up, no errors, looks good.

@kieckhafer kieckhafer merged commit 166cabd into develop Jan 31, 2019
@kieckhafer kieckhafer deleted the feat-aldeed-add-collectionIndex-options branch January 31, 2019 21:22
@jeffcorpuz jeffcorpuz mentioned this pull request Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants