Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mikemurray
Copy link
Member

@mikemurray mikemurray commented Feb 21, 2019

Resolves #4953
Impact: breaking
Type: feature

Issue

Move the product administration tools (Product grid and detail page) into the Operator 2.0 experience.

Solution

  • Reuse a mush code as possible while also updating the presentational component to fit into the new operator experience.
  • Avoiding building anything data related. This means no GraphQL at this time, and minor modifications to the meteor trackers, composers and data fetching.
  • This is a phase 1, and as such not everything will be perfected, and many of the bugs/hiccups that were prevelant in operator 1.0 product editing my or may not have been addressed.

Breaking changes (Super-duper-major)

Reaction is no-longer a customer facing app, it's an administration tool and offers a GraphQL api.

All customer facing views are the responsibility of a separate storefront app that makes use of the GaphQL api. See our example storefront as an example of how to achieve this.

Testing

Login

  1. Ensure you can sign-in as an admin and that you're redirected to "/operator"
  2. Ensure that if you sign-in as a non-admin, that you see the reaction logo, and a signout button
  3. Ensure that if you sign in from the starter-kit, you are correctly redirected back to the starter-kit on successful sgin-in

Products

  1. Load a bunch of products into the app
  2. If you used sample-data ensure that after signin you go to http://localhost:3000/operator/localization and reload translations with the refresh button
  3. Then go to http://localhost:3000/operator/products, or use the navigation bar item "Products"
  4. Be amazed
  5. Then, add, edit, publish products etc, products, variants, options and ensure changes are made as expected.

Signed-off-by: Mike Murray <[email protected]>
…etail page for operator 2.0

Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
…instead of the legacy actionView

Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
Copy link
Member Author

Here are some early #rough screenshots of the progress made. These are not final designs by any means, just a quick move to OP2.0 with some modifications, like the product grid to product table.

not-found
not-found
not-found

Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
@mikemurray mikemurray changed the title [WIP] feat: Operator 2.0 products admin feat: Operator 2.0 products admin Mar 7, 2019
@mikemurray
Copy link
Member Author

New screenshots:

image

image

image

@mikemurray mikemurray requested review from rymorgan and spencern March 7, 2019 22:25
Copy link
Contributor

@rymorgan rymorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from a design perspective (not being able to load up and click around for functionality).

This PR meets the objectives of -

  • Migrating product editing to an admin only experience without a full rethink of our approach.
  • Some small improvements where possible based on admin only approaches such as using tables for products, variants, and options.

Copy link
Contributor

@spencern spencern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spencern spencern merged commit 0ed5d9d into develop Mar 8, 2019
@spencern spencern deleted the feat-4953-mikemuray-op2-products branch March 8, 2019 20:36
@jeffcorpuz jeffcorpuz mentioned this pull request Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants