fix: do not emit afterCartUpdate unless surcharges are updated #5001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <[email protected]>
kieckhafer
previously requested changes
Feb 20, 2019
Member
kieckhafer
left a comment
There was a problem hiding this comment.
If I have no surcharges already applied to a cart (In this case, I never added any to the DB, therefore there were never any added to any order / cart), I get the following:
Error in "afterCartUpdate" consumer TypeError: Cannot read property 'map' of undefined
at Promise.asyncApply (imports/plugins/included/surcharges/server/no-meteor/startup.js:44:32)
at /home/node/.meteor/packages/promise/.0.11.2.1gwulfb.vjny++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/meteor-promise/fiber_pool.js:43:40
=> awaited here:
at Function.Promise.await (/home/node/.meteor/packages/promise/.0.11.2.1gwulfb.vjny++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/meteor-promise/promise_server.js:56:12)
at Promise.asyncApply (imports/node-app/core/util/appEvents.js:24:5)
at /home/node/.meteor/packages/promise/.0.11.2.1gwulfb.vjny++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/meteor-promise/fiber_pool.js:43:40
Signed-off-by: Eric Dobbertin <[email protected]>
kieckhafer
approved these changes
Feb 20, 2019
Member
kieckhafer
left a comment
There was a problem hiding this comment.
👍 looks good with the change. Do not see an infinite loop, nor the issue I mentioned in my previous comment.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4995
Impact: minor
Type: bugfix
Issue
The
afterCartUpdatehandler for surcharges was emitting its ownafterCartUpdateevent even when it hadn't changed the surcharges list at all.Solution
Check whether the surcharges list has changed before emitting.
Breaking changes
None
Testing
See reproduction steps in the linked issue