Add splitOrderItem mutation #5024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
kieckhafer
requested changes
Mar 8, 2019
kieckhafer
reviewed
Mar 8, 2019
Member
There was a problem hiding this comment.
Overall looks good, one issue I came across where Taxes are not split between items, but aside from that:
- subtotal updates as it should
- the items move as they should
- the restrictions on quantity work, you can only move
x-1items, always leaving at least one in the original item - Account restrictions work
Should be good to go once taxes are fixed.
Contributor
Author
|
@kieckhafer The tax and other total recalculation issues should be fixed now |
Signed-off-by: Eric Dobbertin <[email protected]>
kieckhafer
approved these changes
Mar 15, 2019
Member
kieckhafer
left a comment
There was a problem hiding this comment.
👍 Changes look good, Taxes and subtotals now move with the item
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4999
Impact: minor
Type: feature
Changes
A new
splitOrderItemmutation allows you to split one order item into two items, such that the two items are identical other than their quantity and subtotal, and their quantities add up to the original item's quantity.The operator UI does not yet implement this.
splitOrderItemcan be called internally to synchronize from an external system by settingcontext.isInternalCalltotruesplitOrderItemcan be called through GraphQL by any user with "orders" permission for the shop that owns the orderBreaking changes
None
Testing