Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@aldeed
Copy link
Contributor

@aldeed aldeed commented Mar 6, 2019

Part of #4999
Impact: minor
Type: feature

Changes

A new updateOrderFulfillmentGroup mutation allows you to change the tracking and status fields of an order fulfillment group after the order has been placed.

The operator UI now uses this mutation for the tracking update only. Changing the operator UI to use GraphQL for group status updates will be done in a later PR.

  • updateOrderFulfillmentGroup can be called internally to synchronize from an external system by setting context.isInternalCall to true
  • updateOrderFulfillmentGroup can be called through GraphQL by any user with "orders" permission for the shop that owns the order
  • The "orders/updateShipmentTracking" Meteor method is removed in favor of the updateOrderFulfillmentGroup GraphQL mutation

Breaking changes

None

Testing

  1. Place an order.
  2. Verify that the mutation works as described.
  3. Verify that you can update the order fulfillment group status and tracking when authenticated as a user with "orders" role, but not when authenticated as someone else or when not authenticated.
  4. Verify that saving the Tracking field in the operator UI works.

@aldeed aldeed self-assigned this Mar 6, 2019
@aldeed aldeed requested a review from kieckhafer March 6, 2019 04:55
@aldeed aldeed added this to the πŸ” Uncompahgre milestone Mar 6, 2019
@aldeed
Copy link
Contributor Author

aldeed commented Mar 7, 2019

@kieckhafer I add trackingUrl in 1c86ee9 per discussion in the other PR

Copy link
Member

@kieckhafer kieckhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one quick question but good to approve.

orderId,
orderFulfillmentGroupId,
status,
tracking
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See that you noted trackingUrl is not updated here yet. Should we go ahead and add it already to keep this in sync with what the other mutation can do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather wait until we actually add a field in UI for it and need it here.

Signed-off-by: Erik Kieckhafer <[email protected]>
@kieckhafer kieckhafer merged commit 4e19818 into develop Mar 7, 2019
@kieckhafer kieckhafer deleted the feat-aldeed-update-order-group branch March 7, 2019 20:52
@jeffcorpuz jeffcorpuz mentioned this pull request Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants