Allow users to disable plugins via config #5031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldeed
requested changes
Mar 11, 2019
| @@ -0,0 +1,5 @@ | |||
| const disabledPlugins = []; | |||
Contributor
There was a problem hiding this comment.
Can you add a comment above here explaining what goes in the array? At first glance I would have thought the plugin's name, but it looks like actually the directory name.
Also, should we gitignore this file? (after this initial commit)
Collaborator
Author
|
@aldeed I wonder if sort of tangential to this if we should move all the collection creation stuff for |
Contributor
|
@zenweasel Yes as a general rule we need to get all collection creation moved into the related plugin startup. It would be done soon as part of #4996 if not now |
Collaborator
Author
|
@aldeed Requested changes made |
aldeed
approved these changes
Mar 12, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #NA
Impact: minor
Type: feature
Issue
There is no good and easy way to disable a plugin through configuration
Solution
Keep a list of disabled plugins and don't load/import any of those
Breaking changes
None
Testing
.reaction/pluginConfigsand addsearch-mongoto the array fordisabledPlugins.