Fix: startup asset provisioning #5033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…startup Signed-off-by: Daniel Castellon <[email protected]>
c2f038d to
fdd7183
Compare
aldeed
reviewed
Mar 11, 2019
Contributor
aldeed
left a comment
There was a problem hiding this comment.
@dancastellon I think it would probably be sufficient to add as a dev dependency right? In a production image, I'm pretty sure the asset copying happens on build. (In fact, the prod build is probably still using the CLI.)
Contributor
Author
|
@aldeed All set here |
aldeed
approved these changes
Mar 12, 2019
Contributor
aldeed
left a comment
There was a problem hiding this comment.
Missing signoff on the last commit but seems good to me otherwise
Signed-off-by: Daniel Castellon <[email protected]>
ce488d6 to
1c09ea2
Compare
Contributor
Author
|
@aldeed Signed off |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5032
Impact: minor
Type: bugfix
Issue
I discovered asset provisioning was broken when trying to create custom email templates by placing them in my plugin's
privatefolder.Solution
This commit copied logic from CLI to allow Reaction to start without it. In doing so, the
fs-extrapackage that CLI uses wasn't included.fs-extraprovides thecopySyncfunction that recursively copies a directory. Without it, startup was throwing an error aboutcopySyncnot existing, and custom pluginprivatedirectories weren't copied over to app'sprivatedirectory. The fix was to simply add the package and change an import line.Breaking changes
None
Testing
privatedirectoryProvisioning assets...