feat: remove search plugins #5053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes our `search-mongo` plugin from the `imports/plugins/included` directory of `reaction`. We're doing this because we've found that some of the app event hooks within this plugin fire even when the plugin is disabled. When a custom search plugin is used, having these events run can cause considerable slowness when publishing a product to the catalog. This issue is exacerbated when importing and publishing large sets of products simultaneously. We'll include `search-mongo` as an optional plugin, but keep it OSS. BREAKING CHANGE: Removes `search-mongo` plugin from `included` plugins. Install `search-mongo` into your `custom` plugins directory to maintain identical functionality. Signed-off-by: Spencer Norman <[email protected]>
Signed-off-by: Spencer Norman <[email protected]>
Removes order operator search bits. Also updates `searchcollections.js` util files to run `buildAccountSearch` and `buildOrderSearch` as noop. Signed-off-by: Spencer Norman <[email protected]>
rosshadden
approved these changes
Mar 19, 2019
Merged
|
We should consider adding MongoDB Atlas Search to the framework. It's free for most people and is a fast-growing and simple to use alternative to text matching in MongoDB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: breaking
Type: feature
Issue
This PR removes the
search-mongoandui-searchplugins from theimports/plugins/includeddirectory ofreaction. It also removes the search bar from the operator orders UI that depended upon thesearch-mongo. It cleans up the util functions run by some of the migrations used to setup the mongo search collections.We're doing this because we've found that some of the app event hooks within this plugin fire even when the plugin is disabled. Having these events run can cause considerable slowness when publishing a product to the catalog. This issue is exacerbated when importing and publishing large sets of products simultaneously.
When updating our storefront and operator UIs, we've moved away from using this search package. While there are better search options for most users of Reaction, such as ElasticSearch, we do plan to support basic search functionality out of the box for both the storefront and for the operator UIs.
The operator order management UI is very sluggish. This PR does not attempt to resolve any issues related to the order management UI.
Breaking changes
Removes order search bar from operator order UI.
Removes
search-mongoandui-searchplugins fromreaction.Testing