Update Material-UI 4.x #5278
Merged
Update Material-UI 4.x #5278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Theme.spacing() is now a function. Signed-off-by: Mike Murray <[email protected]>
`spacing` is now from 0 - 10, where `3 * base spacing unit of 8` will still equal `24` Signed-off-by: Mike Murray <[email protected]>
`spacing` is now from 0 - 10, where `1 * base spacing unit of 8` will still equal `8` Signed-off-by: Mike Murray <[email protected]>
`spacing` is now from 0 - 10, where `5 * base spacing unit of 8` will still equal `40` Signed-off-by: Mike Murray <[email protected]>
0b9e30d to
e660e8d
Compare
Member
Author
|
The remaining issues I see seem to be some icon size and list item spacing issues. |
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
kieckhafer
reviewed
Jul 19, 2019
Signed-off-by: Mike Murray <[email protected]>
kieckhafer
reviewed
Jul 19, 2019
Signed-off-by: Erik Kieckhafer <[email protected]>
kieckhafer
approved these changes
Jul 19, 2019
Member
kieckhafer
left a comment
There was a problem hiding this comment.
I made a couple updates to change spacing sizes in a couple files that were missed, but everything looks good after those couple changes 👍
Signed-off-by: Erik Kieckhafer <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: major
Type: feature|chore
Issue
MUI 4.0 release a few months back and adds some refinements to an already super useful library. We were on 3.9 previously.
Solution
Breaking changes
theme.spacing.unitis will betheme.spacing(). Updated all our uses oftheme.spacing.unittotheme.spacing(). This will be a breaking change for v5.0-10which are multiples of the base spacing unit of 8. Values about 10 with show a warning in the console.checkboxesandicon buttonswill need<TableCell paddingCheckbox>or<TableCell paddingNone>, otherwise the rows will be much taller than necessary.I say these are mostly visual breaking changes. The app should run with maybe some extra padding or warnings to update to the new features for older plugins.
Testing