Add DataLoaders for Shops and SimpleInventory #5294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosshadden
approved these changes
Jul 9, 2019
focusaurus
suggested changes
Jul 9, 2019
imports/plugins/included/simple-inventory/server/no-meteor/utils/createDataLoaders.test.js
Show resolved
Hide resolved
…ps and SimpleInventoryByVariantId Signed-off-by: Alex Haproff <[email protected]>
d8e1070 to
0991274
Compare
added 5 commits
July 10, 2019 10:43
Signed-off-by: Alex Haproff <[email protected]>
Signed-off-by: Alex Haproff <[email protected]>
…ateDataLoaders to TestApp Signed-off-by: Alex Haproff <[email protected]>
…urned from loadMany in inventoryForProductConfigurations and disabling of DataLoader cache when running in test env Signed-off-by: Alex Haproff <[email protected]>
… in tests Signed-off-by: Alex Haproff <[email protected]>
focusaurus
approved these changes
Jul 10, 2019
Contributor
|
snyk is failing because it fails on all pull requests from forks. build and test is passing. Merging. Thanks @alex-haproff ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves 70
Impact: minor
Type: feature
Issue
The original feature request is tracked here reactioncommerce/reaction-feature-requests#70
Solution
With the infrastructure for DataLoaders in place, this PR adds first couple of DataLoaders for Shops and SimpleInventory.
Shopswill benefit product listing pages as product and variant resolvers all queryShopscollection for each product.SimpleInventoryquery benefits from batching.Breaking changes
None.