chore: fix all react/no-deprecated and react/prop-type eslint warnings
#5307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
This was referenced Jul 11, 2019
Closed
Member
Author
|
@machikoyasuda not sure what the deal is with the DCO issue - it involves Maria's commits that aren't even in this branch. I've filed a ticket with them to see if they know what's going on: dcoapp/app#115 |
machikoyasuda
approved these changes
Jul 13, 2019
Contributor
|
@kieckhafer You have 2 commits incorrectly signed off. To fix, head to your local branch and run:
Now your commits will have your sign off. Next run
|
Member
Author
|
@machikoyasuda but those aren't my commits, and they aren't in this branch at all. They are commits from Maria... somewhere in the app. |
…sling-reactNoDeprecated
Signed-off-by: Erik Kieckhafer <[email protected]>
Member
Author
|
Fixed... somehow. It just went away when I made a new commit. Doesn’t make any sense to me, hopefully the ticket I made in that repo can provide some answers. |
This was referenced Jul 13, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5247 & #5271
Impact: minor
Type: chore
Issue
We currently have many
react/no-deprecatedandreact/prop-typeeslint warnings.Solution
Fix (or disable) these warnings, and then update our
eslintrules to makereact/no-deprecatedandreact/prop-typeanerrorso new violations are not introduced.I have update the components to use the
UNSAFE_version fo deprecated react life cycle methods, as these components will be updated to be functional components in the future.Updated rules: reactioncommerce/reaction-eslint-config#15
Breaking changes
None.
Testing
react/no-deprecatedandreact/prop-typewarnings (and no errors)