chore: use npm command rather than meteor npm #5328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in loadPlugins Signed-off-by: Eric Dobbertin <[email protected]>
rosshadden
approved these changes
Jul 16, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: chore
Issue
Running the
.reaction/scripts/build.mjsNode script finds and loads all plugins. There was one Meteor dependency in this script, preventing it from working if you haven't installed Meteor in the environment.Solution
The
meteor npm icommand this script runs in each plugin folder is changed tonpm i. This means there will no longer be a Meteor layer ensuring that the correct version of NPM is used. However, we keep the version in the image consistent with the version that Meteor ships with, so this shouldn't be a problem.Breaking changes
None.
Testing
Verify you can run
node --experimental-modules ./.reaction/scripts/build.mjswithout errors in an environment that doesn't have themeteorCLI available.