Fix - Missing translations/CRUD Admin-UI: Admin user account shopId w… #5377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as replaced with newly created shop, after first shop owner invitation
kieckhafer
reviewed
Oct 7, 2019
| Logger.info("Created shop: ", newShopId); | ||
|
|
||
| Promise.await(appEvents.emit("afterShopCreate", { createdBy: userId, shop: newShop })); | ||
| Promise.await(appEvents.emit("afterShopCreate", { createdBy: shopAdminUserId, shop: newShop })); |
Member
There was a problem hiding this comment.
Suggested change
| Promise.await(appEvents.emit("afterShopCreate", { createdBy: shopAdminUserId, shop: newShop })); | |
| Promise.await(appEvents.emit("afterShopCreate", { createdBy: userId, shop: newShop, shopAdminUserId: shopAdminUserId || userId })); |
Member
|
Thanks for the PR @TilenKreca. I didn't have the ability to edit your branch, so I created another PR with a few more updates: #5694 I'm going to close this PR, please follow the status in #5694 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5376
Impact: critical
Type: bugfix
Issue
Primary shopId in accounts collection, gets replaced with newly created shop id, after new shop owner invitation. Described fully in issue #5376
Solution
Is provided by this pull request.
Breaking changes
No breaking changes or functional changes
Testing
Needs testing