fix: red textfields #5371
Merged
fix: red textfields #5371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isValid can be true for success, false for error, and undefined for the unvalidated state. Signed-off-by: Mike Murray <[email protected]>
kieckhafer
approved these changes
Jul 25, 2019
Member
kieckhafer
left a comment
There was a problem hiding this comment.
👍 can confirm the red is dead
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: critical
Type: bugfix
Issue
Some text fields have the red error state, even though they contain valid data.
Solution
isValidcan be true for success, false for error, and undefined for the default state.Breaking changes
none
Testing