Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mikemurray
Copy link
Member

@mikemurray mikemurray commented Jul 30, 2019

Resolves part of #5385
Impact: minor
Type: feature

Issue

Add ability to filter products list by product id.

Solution

Necessary evils have been committed in order to push this feature forward. This will need to be revisited at some point to addGraphQL queries for the entire products table/product detail admin panels

  • Add filter for product id in publication
  • Add Session var "filterByProductIds"

Breaking changes

none.

Testing

  1. Using a large data set (you know the one) use the following URL
  2. http://localhost:3000/operator/products?productIds=1284997,1286853
  3. See the product filter in the table
  4. http://localhost:3000/operator/products?productIds=OTHER_PRODUCT_IDS
  5. See the product filter in the table
  6. From the console do Session.set("filterByProductIds", ["1284997", "1286853"])
  7. See the list filter by product ids
  8. Try using different ids. The Session var overrides the URL query string

@cshepherd
Copy link
Contributor

Staged and tested, LGTM!

@machikoyasuda machikoyasuda merged commit 0208710 into develop Jul 30, 2019
@machikoyasuda machikoyasuda deleted the feat-5385-bilk-product-filter branch July 30, 2019 18:20
@kieckhafer kieckhafer mentioned this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants