feat(product table): show Action dropdown, even if no products are selected #5391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are selected. disable actions if products are not selected Signed-off-by: Machiko Yasuda <[email protected]>
machikoyasuda
commented
Jul 31, 2019
imports/plugins/included/product-variant/components/productGrid.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Machiko Yasuda <[email protected]>
kieckhafer
reviewed
Jul 31, 2019
imports/plugins/included/product-variant/components/productGrid.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Machiko Yasuda <[email protected]>
7161848 to
8a10b32
Compare
added 2 commits
July 30, 2019 23:12
Signed-off-by: Machiko Yasuda <[email protected]>
Signed-off-by: Machiko Yasuda <[email protected]>
8a10b32 to
d64c42a
Compare
Contributor
Author
|
This React props error shows up in the console, but this error also already appears in |
cshepherd
approved these changes
Jul 31, 2019
Contributor
cshepherd
left a comment
There was a problem hiding this comment.
LGTM, also confirmed console warning isn't your fault
cassytaylor
approved these changes
Jul 31, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5388
Impact: minor
Type: feature
Issue
In the new Bulk Product/Tag action flow, it's required that the Action dropdown menu be available to click - even if products are not selected.
Solution
This PR changes the
renderToolbar()method to 1) always show the dropdown, but 2)disablethe action options if there are no products selected.Breaking changes
None
Testing