Feat #5379 integrate catalyst button #5406
Merged
+47
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
July 31, 2019 19:29
Signed-off-by: Christopher Shepherd <[email protected]>
… in Operator UI Signed-off-by: Christopher Shepherd <[email protected]>
…gs fragment Signed-off-by: Christopher Shepherd <[email protected]>
Signed-off-by: Christopher Shepherd <[email protected]>
Signed-off-by: Christopher Shepherd <[email protected]>
Signed-off-by: Christopher Shepherd <[email protected]>
Signed-off-by: Christopher Shepherd <[email protected]>
…form Signed-off-by: Christopher Shepherd <[email protected]>
Signed-off-by: Christopher Shepherd <[email protected]>
Signed-off-by: Christopher Shepherd <[email protected]>
Signed-off-by: Christopher Shepherd <[email protected]>
added 3 commits
August 5, 2019 16:09
Signed-off-by: Christopher Shepherd <[email protected]>
Signed-off-by: Christopher Shepherd <[email protected]>
machikoyasuda
approved these changes
Aug 6, 2019
Contributor
|
@machikoyasuda @cshepherd Should this be merged? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5379
Impact: minor
Type: feature
Issue
#5379
Solution
Fix a bug wherein the case of the letter 'P' in 'Forgot Password' changes as the login page renders.
Transition from older design system Button to Catalyst Button for the following 9 cases:
Breaking changes
N/A
Testing
Ensure that the case of the letter 'p' in 'Reset password' does not change as the /operator login form renders.
Ensure that the design isn't broken by these changes, in the following places:
Settings > Shipping > Shipping Method form
Settings > Shop > Sitemap options form fragment
Settings > Shop > Address Validation methods 'Delete' button
Tags > Create a Tag button
Tags > Edit > Hero Image Upload and Delete buttons
Tags > Edit > Cancel and Save buttons at top of page
Tags > Pagination buttons (present/active when over 10 tags are present, shown here with broken i18n text)
Settings > Taxes > Save Changes button
