chore: remove unused shop.appVersion #5429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <[email protected]>
45 tasks
kieckhafer
approved these changes
Aug 7, 2019
Member
kieckhafer
left a comment
There was a problem hiding this comment.
👍 App starts, migration ran, database does not have appVersion in it
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: chore
Part of epic #4996
Issue
Startup code is setting
appVersionproperty on every Shop document. Nothing uses this. It's accessible from thesystemInformationGraphQL query if needed.Solution
appVersionfrom shop schemaappVersionproperty from the databaseBreaking changes
If custom code is relying on
shop.appVersion, it will need to be updated to use thesystemInformationGraphQL query.Testing
appVersionfield. Logging should also show that migration 70 ran successfully.