ref: move filter outside of admin check #5434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Kieckhafer <[email protected]>
4782292 to
2968912
Compare
Signed-off-by: Erik Kieckhafer <[email protected]>
…FilterPermissions
aldeed
approved these changes
Aug 8, 2019
Contributor
|
Code 👍 , didn't test |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: refactor
Issue
Tag filter implemented in #5232 was only accessible by admin accounts, as it was inside of a permissions check.
Solution
As we've had some requests for all users to be able to use this, we've moved the filter ability outside the admin permission check.
@mikemurray and I initially decided to only allow admin users the permission, as we wanted to further discuss performance impacts as this hits the database frequently. If performance becomes an issue here, we can revisit.
Breaking changes
None
Testing
Shop Manager).