feat: remove startup template import #5430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
45 tasks
kieckhafer
approved these changes
Aug 7, 2019
Member
kieckhafer
left a comment
There was a problem hiding this comment.
👍 Looks good, app works as expected, no changes to editing templates.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: breaking
Type: feature
Part of epic #4996
Issue
There is startup code that loads template assets from
/private. This feature isn't used in 2.x because only emails currently use templates, and they are loaded from code files by theemail-templatesplugin.Solution
Because loading these static assets is a Meteor feature, we've removed this startup code.
Breaking changes
The following are removed:
Reaction.registerTemplateTemplatescollectionTesting